rhtyd commented on a change in pull request #2468: [4.11] VR: minor fixes URL: https://github.com/apache/cloudstack/pull/2468#discussion_r172029122
########## File path: systemvm/debian/etc/systemd/system/cloud-postinit.service ########## @@ -1,7 +1,7 @@ [Unit] Description=CloudStack post-patching init script After=cloud-early-config.service network.target local-fs.target -Before=ssh.service +Before=ssh.service apache2.service Review comment: I checked the code again, the cloud-early-config service runs first that patches the vr/systemvm using the new systemvm.iso (that will contain this change) and does a systemctl daemon-reload before cloud-postinit could run. In that case, it's possible that a new systemvmtemplate is not needed. We'll need to verify this manually, or via the systemd flame graph (@resmo can you share/attach the `systemd-analyse plot > svg`? or some other log/output) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
