Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option 
on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r174262477
 
 

 ##########
 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 ##########
 @@ -3853,7 +3856,7 @@ private void 
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
         case Stopped:
         case Migrating:
             s_logger.info("VM " + vm.getInstanceName() + " is at " + 
vm.getState() + " and we received a power-off report while there is no pending 
jobs on it");
-            if(vm.isHaEnabled() && vm.getState() == State.Running && 
vm.getHypervisorType() != HypervisorType.VMware && vm.getHypervisorType() != 
HypervisorType.Hyperv) {
+            if(vm.isHaEnabled() && vm.getState() == State.Running && 
HaVmRestartHostUp.value() && vm.getHypervisorType() != HypervisorType.VMware && 
vm.getHypervisorType() != HypervisorType.Hyperv) {
 
 Review comment:
   Yea, that sounds like a good idea, i am booked up here for a while, but it 
sounds like a good idea

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to