DaanHoogland commented on a change in pull request #2493: CLOUDSTACK-10326:
Prevent hosts fall into Maintenance when there are running VMs on it
URL: https://github.com/apache/cloudstack/pull/2493#discussion_r175301207
##########
File path: engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java
##########
@@ -151,8 +151,5 @@
boolean isPowerStateUpToDate(long instanceId);
- /**
- * List running VMs which host and lastHost id are the same
- */
- List<VMInstanceVO> listRunningVmsByHostAndLastHostSameId(long hostId);
+ List<VMInstanceVO> listNonMigratingVmsByHostEqualsLastHost(long hostId);
Review comment:
hm, that is not very clear, the name is stating cause and conclusion. I
suggest listVmsByHostEqualsLastHost()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
