marcaurele commented on a change in pull request #2481: CLOUDSTACK-10320 -
Invalid pair for response object breaking response parsing
URL: https://github.com/apache/cloudstack/pull/2481#discussion_r175355297
##########
File path: framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java
##########
@@ -1323,6 +1327,11 @@ protected void addJoins(StringBuilder str,
Collection<JoinBuilder<SearchCriteria
public Pair<List<T>, Integer> searchAndDistinctCount(final
SearchCriteria<T> sc, final Filter filter) {
List<T> objects = search(sc, filter, null, false);
Integer count = getDistinctCount(sc);
+ // Count cannot be 0 if there is at least a result in the list, see
CLOUDSTACK-10320
+ if (count == 0 && !objects.isEmpty()) {
+ // Cannot assume if it's more than one since the count is distinct
vs search
+ count = 1;
Review comment:
Because the search is mostly done against views which don't return distinct
rows due to the *not so smart* queries fetching the ~details~ resource tags
rows. Look at the APIHelper with iterate on duplicate row entries, but only
append the details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
