marcaurele commented on a change in pull request #2578: api: add command to 
list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182655083
 
 

 ##########
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##########
 @@ -3760,6 +3767,22 @@ protected ResourceDetailResponse 
createResourceDetailsResponse(ResourceDetail re
         return resourceDetailResponse;
     }
 
+    @Override
+    public ListResponse<ManagementServerResponse> 
listManagementServers(ListMgmtsCmd cmd) {
+        ListResponse<ManagementServerResponse> response = new ListResponse<>();
+        List<ManagementServerResponse> result = new ArrayList<>();
+        for (ManagementServerHostVO mgmt : managementServerHostDao.listAll()) {
 
 Review comment:
   Another shortcut, I'm not doing any pagination since it's kind of overkill 
for the number of management servers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to