rafaelweingartner commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address URL: https://github.com/apache/cloudstack/pull/2595#discussion_r183678534
########## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java ########## @@ -883,6 +885,73 @@ public void saveExtraDhcpOptions(final String networkUuid, final Long nicId, fin return new Pair<NicProfile, Integer>(vmNic, Integer.valueOf(deviceId)); } + /** + * If the requested IPv4 address from the NicProfile was configured then it configures the IPv4 address, Netmask and Gateway to deploy the VM with the requested IP. + */ + protected void configureNicProfileBasedOnRequestedIp(NicProfile requestedNicProfile, NicProfile nicProfile, Network network) { + String requestedIpv4Address = requestedNicProfile.getRequestedIPv4(); + if (requestedIpv4Address == null) { Review comment: You can extract lines 893-902 to a specific method that validates `requestedIpv4Address ` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services