DaanHoogland commented on a change in pull request #2399: CLOUDSTACK-10223
delete snapshots when deleting domain
URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184846572
##########
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) {
@Override
public boolean deleteSnapshotDirsForAccount(long accountId) {
- List<VolumeVO> volumes = _volsDao.findByAccount(accountId);
+ List<VolumeVO> volumes =
_volsDao.findIncludingRemovedByAccount(accountId);
Review comment:
have to check, you might just have found an old hidden bug ,
@rafaelweingartner . On the other hand I have seen stranger things, a template
is a volume of sorts isn't it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
