rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR
downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184939883
##########
File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
##########
@@ -1508,19 +1519,33 @@ public boolean restartVpc(final long vpcId, final
boolean cleanUp, final boolean
// Change the VPC in order to get it updated after the end of
// the restart procedure.
- _vpcDao.update(vpc.getId(), entity);
+ if (_vpcDao.update(vpc.getId(), entity)) {
+ vpc = entity;
+ }
// If the offering and redundant column are changing, force the
// clean up.
forceCleanup = true;
}
if (forceCleanup) {
Review comment:
The body of IF is rather small already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
