mike-tutkowski commented on issue #2501: Only perform certain actions with managed storage if the VM is s… URL: https://github.com/apache/cloudstack/pull/2501#issuecomment-385595549 I’m not sure I understand the recommendation. Could you specify in more detail? Thanks! On Apr 30, 2018, at 9:58 PM, Nitin Kumar Maharana <[email protected]<mailto:[email protected]>> wrote: @nitin-maharana commented on this pull request. ________________________________ In engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java<https://github.com/apache/cloudstack/pull/2501#discussion_r185162940>: > - storageMgr.removeStoragePoolFromCluster(oldHostId, vol.get_iScsiName(), pool); + if (lastClusterId != clusterId) { @mike-tutkowski<https://github.com/mike-tutkowski>, I doubt if we need to handle the else part where the target cluster is same as the old one. Where we can put a warning/error that this action cannot be performed on the same cluster different host etc.. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/2501#pullrequestreview-116497921>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH44NKORLwM5LH2JuOr5zNhVqFVN-ks5tt91IgaJpZM4S2HMH>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
