mike-tutkowski commented on issue #2503: Support multiple volume access groups per compute cluster URL: https://github.com/apache/cloudstack/pull/2503#issuecomment-385595671 Sounds good. I was under the impression, though, that we always wanted to squash commits going into a PR, but I guess we can always squash them before merging, if we want to. On Apr 30, 2018, at 10:08 PM, dahn <[email protected]<mailto:[email protected]>> wrote: @DaanHoogland commented on this pull request. ________________________________ In plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/SolidFireSharedPrimaryDataStoreLifeCycle.java<https://github.com/apache/cloudstack/pull/2503#discussion_r185163509>: > @@ -245,7 +243,7 @@ public DataStore initialize(Map<String, Object> dsInfos) { details.put(SolidFireUtil.VOLUME_ID, String.valueOf(sfVolume.getId())); - parameters.setUuid(iqn); + parameters.setUuid(UUID.randomUUID().toString()); I am not talking separate PRs, @mike-tutkowski<https://github.com/mike-tutkowski> . Only separate commits. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/2503#discussion_r185163509>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SHwcvhhk2SgzNOA-eh6dZH4NKSM8aks5tt9-QgaJpZM4S2KI5>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
