marcaurele commented on a change in pull request #2593: api: move default 
response from XML to JSON
URL: https://github.com/apache/cloudstack/pull/2593#discussion_r185403697
 
 

 ##########
 File path: server/src/main/java/com/cloud/api/ApiServlet.java
 ##########
 @@ -170,12 +170,6 @@ void processRequestInContext(final HttpServletRequest 
req, final HttpServletResp
 
         try {
 
-            if (HttpUtils.RESPONSE_TYPE_JSON.equalsIgnoreCase(responseType)) {
 
 Review comment:
   It's some dummy code. The content type is set when writing the String 
response to the HttpResponse later on. Doing it so early does not have much 
sense. See `HttpUtils.writeHttpResponse()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to