khos2ow commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker URL: https://github.com/apache/cloudstack/pull/2584#issuecomment-387476453 Why do you think it's going to break @rhtyd ? This PR is a cleanup and to change a `Map` data structure to essentially a `LinkedList`. On the other hand it should actually prevent breaking (because we wouldn't need to add to dozens of places when new upgrade path required). @rafaelweingartner Thanks for providing the thread, I'll take a look later. And as I mentioned earlier the way I thought about this is, to agree on a cut-off version to migrate to Flyway. That's also the way implemented in #2479. Everything up to that version is going to be handled with the _old_ way, and afterward with Flyway. I tested: - fresh install of 4.12.0.0 - upgrade from 4.11.0.0 - upgrade from 4.10.0.0 - upgrade from 4.9.0 I added a unit test for _unknown_ version to upgrade from and to. But the rest of unit tests look good enough. May be we can add another one from older versio (e.g. 4.6-ish) to some new version (e.g. 4.11-ish), but I don't think it would add much value.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
