rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187320904
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 180000, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+ int portsPerDvPortGroup = _portsPerDvPortGroup;
+ AboutInfo about = hostMo.getHostAboutInfo();
+ if (about != null) {
+ String version = about.getApiVersion();
+ if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
Review comment:
do you need that second condition there `_portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
