DaanHoogland commented on a change in pull request #2503: Support multiple
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r187576845
##########
File path:
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
##########
@@ -300,7 +311,7 @@ public static String getValue(String keyToMatch, String
url, boolean throwExcept
}
public static String getSolidFireAccountName(String csAccountUuid, long
csAccountId) {
- return "CloudStack_" + csAccountUuid + "_" + csAccountId;
+ return SF_CS_ACCOUNT_PREFIX + csAccountUuid + "_" + csAccountId;
Review comment:
@mike-tutkowski @rafaelweingartner looking at the method it does not seem to
be getting or retrieving anything, just processing the parameters to produce a
valid name, hence my format-prefix sugestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
