DaanHoogland commented on a change in pull request #2629: Fix primary storage
count when deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#discussion_r187578509
##########
File path: server/src/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -1259,92 +1261,139 @@ private VolumeVO orchestrateResizeVolume(long
volumeId, long currentSize, long n
}
}
- @Override
@DB
+ @Override
@ActionEvent(eventType = EventTypes.EVENT_VOLUME_DELETE, eventDescription
= "deleting volume")
- public boolean deleteVolume(long volumeId, Account caller) throws
ConcurrentOperationException {
+ /**
Review comment:
great refactor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
