nvazquez commented on a change in pull request #2683: Add default L2 network
offerings
URL: https://github.com/apache/cloudstack/pull/2683#discussion_r193401147
##########
File path:
engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java
##########
@@ -221,4 +224,41 @@ public boolean isUsingServicePackage(String uuid) {
return false;
}
+
+ @Override
+ public void persistDefaultL2NetworkOfferings() {
Review comment:
There are 2 occurrences: one as you mention for new environments (init
global setting = false) and the other on NetworkOrchestrator.configure(). You
are right, to support the second case we should check if the offerings already
exist before adding them, I'll refactor it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
