rafaelweingartner commented on a change in pull request #2710: comply with api 
key constraint
URL: https://github.com/apache/cloudstack/pull/2710#discussion_r195115719
 
 

 ##########
 File path: server/src/com/cloud/user/AccountManagerImpl.java
 ##########
 @@ -1734,6 +1734,8 @@ public Boolean doInTransaction(TransactionStatus status) 
{
                 UserVO newUser = new UserVO(user);
 
 Review comment:
   Why creating a new user entry? I mean, isn't this a matter of simply 
updating the accountId of the user? Then, you would not change the UUID of the 
"old" user entry, and you would also not need to update the keys and then mark 
the user as removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to