GabrielBrascher commented on a change in pull request #1730: VMTemplateZone
needs some love
URL: https://github.com/apache/cloudstack/pull/1730#discussion_r204042229
##########
File path:
engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java
##########
@@ -55,22 +55,22 @@ public VMTemplateZoneDaoImpl() {
public List<VMTemplateZoneVO> listByZoneId(long id) {
SearchCriteria<VMTemplateZoneVO> sc = ZoneSearch.create();
sc.setParameters("zone_id", id);
- return listIncludingRemovedBy(sc);
+ return listBy(sc);
}
@Override
public List<VMTemplateZoneVO> listByTemplateId(long templateId) {
SearchCriteria<VMTemplateZoneVO> sc = TemplateSearch.create();
sc.setParameters("template_id", templateId);
- return listIncludingRemovedBy(sc);
+ return listBy(sc);
}
@Override
public VMTemplateZoneVO findByZoneTemplate(long zoneId, long templateId) {
Review comment:
This is the one that we might need to have some eyes on to ensure it will be
ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
