bennysp opened a new pull request #2779: Changed to use ifcfg library for cross compatibility of OS /version URL: https://github.com/apache/cloudstack/pull/2779 ## Description <!--- Describe your changes in detail --> Changed to use pip library [ifcfg](https://github.com/ftao/python-ifcfg) instead of OS ifconfig due to ifconfig format changes across OS and versions. <!-- For new features, provide link to FS, dev ML discussion etc. --> Current bug request: https://github.com/apache/cloudstack/issues/2777 <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> Install CentOS 7; Make sure `yum update -y` has been performed; At the point of agent setup, review setup.log and you will notice there are no ip address, netmask or broadcast set. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> Fixes:#2777 ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> 1. Installed fresh Centos 7 (1804) 2. Followed "quick start guide" on one server 3. Got to the "add a host" section and it would fail. *Note:* Separate issue, but I also had to install, at minimum, `yum install openvswitch.x86_64 -y` or else the code (line 109) will fail when it tries to use the command `ovs-vsctl` in this same file. <!-- Include details of your testing environment, and the tests you ran to --> After swapping out these PR changes and installing openvswitch, I was finally able to add my host correctly. <!-- see how your change affects other areas of the code, etc. --> This does not affect other areas of the code, but forces you to install an external library python-ifcfg. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
