rafaelweingartner commented on a change in pull request #2776: Issue 2774:
Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r206971372
##########
File path:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -196,10 +196,16 @@ public StrategyPriority canHandle(DataObject srcData,
DataObject destData) {
}
private boolean isVolumeOnManagedStorage(VolumeInfo volumeInfo) {
Review comment:
What can I do then?! ;)
In my opinion big methods should always be broken into smaller methods (up
to ~10 lines). Then, these smaller methods need clear and concise
documentation. Moreover, all methods should always be unit-tested (no excuse,
no exceptions). That is a way to save great deal of time and bugs in code
addition and refactoring. Not to say that unit tests cost way less to run than
integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
