mike-tutkowski commented on issue #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to… URL: https://github.com/apache/cloudstack/pull/2776#issuecomment-411817362 OK, thanks for the clarification, Rafael. I will look at Daan’s unit test today. On Aug 9, 2018, at 5:09 AM, Rafael Weingärtner <[email protected]<mailto:[email protected]>> wrote: @rafaelweingartner commented on this pull request. ________________________________ In engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java<https://github.com/apache/cloudstack/pull/2776#discussion_r208890155>: > @@ -196,10 +196,16 @@ public StrategyPriority canHandle(DataObject srcData, DataObject destData) { } private boolean isVolumeOnManagedStorage(VolumeInfo volumeInfo) { @mike-tutkowski<https://github.com/mike-tutkowski> the PR I said I wanted to create some unit tests is not this one, it is the other one I worked. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/2776#discussion_r208890155>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH5gYYsN-hRc7V2cgpLyM9rzQUP3Kks5uPBgsgaJpZM4ViYUg>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
