mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412720498 Sure, open a PR and feel free to tag me when you would like a review. Thanks! On Aug 13, 2018, at 6:41 PM, Rafael Weingärtner <notificati...@github.com<mailto:notificati...@github.com>> wrote: As far as I know, if you migrate a volume from one primary storage to another, there should never exist any primary storage-based snapshots of this volume after the migration has taken place. That being the case, I don't think you should get back primary storage-based snapshots from snapshotFactory.getSnapshots that are from different primary storages I do agree with you, but that is not how it is working right now. Should we fix that method then? I can open a PR tomorrow then. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/1740#issuecomment-412713958>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH9fNf0Es9IA7wUeNBwklFvV7QuY9ks5uQhypgaJpZM4KiQ0->.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
