mike-tutkowski commented on issue #2808: Fix the problem at #1740 when it loads all snapshots in the primary storage URL: https://github.com/apache/cloudstack/pull/2808#issuecomment-413354364 The code LGTM. Also, I have run the particular managed-storage test suite (this one only contains two tests) that initially led me to #1740 and both tests in it passed: test_online_migrate_volume_from_nfs_storage_to_managed_storage (TestOnlineStorageMigration.TestOnlineStorageMigration) ... === TestName: test_online_migrate_volume_from_nfs_storage_to_managed_storage | Status : SUCCESS === ok test_online_migrate_volume_with_snapshot_from_nfs_storage_to_managed_storage (TestOnlineStorageMigration.TestOnlineStorageMigration) ... === TestName: test_online_migrate_volume_with_snapshot_from_nfs_storage_to_managed_storage | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 2 tests in 472.520s OK
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
