rhtyd commented on a change in pull request #2799: systemvmtemplate: new 4.11.2 
template and fixes
URL: https://github.com/apache/cloudstack/pull/2799#discussion_r211554243
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/setup/common.sh
 ##########
 @@ -578,24 +578,13 @@ setup_ntp() {
 }
 
 routing_svcs() {
-   systemctl disable --now cloud
-   systemctl disable --now nfs-common
-   systemctl disable --now portmap
-   systemctl enable apache2
-   systemctl enable haproxy
    echo "haproxy apache2" > /var/cache/cloud/enabled_svcs
    echo "cloud nfs-common portmap" > /var/cache/cloud/disabled_svcs
    if [ "$RROUTER" -eq "1" ]
    then
-       systemctl disable --now dnsmasq
-       systemctl enable conntrackd
-       systemctl enable keepalived
        echo "keepalived conntrackd" >> /var/cache/cloud/enabled_svcs
        echo "dnsmasq" >> /var/cache/cloud/disabled_svcs
    else
-       systemctl disable --now conntrackd
-       systemctl disable --now keepalived
-       systemctl enable dnsmasq
 
 Review comment:
   @wido it's duplicated here, we do that in the cloud-postinit service now 
based on the enabled/disabled svcs file. See the postinit.sh file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to