GabrielBrascher commented on a change in pull request #2595: CLOUDSTACK-10199:
Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r212260149
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -860,6 +860,11 @@ public void saveExtraDhcpOptions(final String
networkUuid, final Long nicId, fin
NicVO vo = new NicVO(guru.getName(), vm.getId(), network.getId(),
vm.getType());
+ DataCenterVO dcVo = _dcDao.findById(network.getDataCenterId());
+ if (dcVo.getNetworkType() == NetworkType.Basic) {
+ configureNicProfileBasedOnRequestedIp(requested, profile, network);
Review comment:
@fmaximus I changed the execution flow; now this workflow will be executed
just in case of a basic network.
After this change I could add IPv4 either in an advanced network, with a
'guest IP', and in a basic network with a 'public IP' (from the IPAddressVO in
this case). Thanks again for pointing that issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
