rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-422342539 Test LGTM, but I think the code could be further refactored. I'm unable to find time to do that @nitin-maharana but please see parts of the code where you see several ifs-elses, see how you can improve that and also add more tests?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
