PaulAngus commented on a change in pull request #2869: Fix some Marvin smoke
tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r221847464
##########
File path: test/integration/smoke/test_deploy_virtio_scsi_vm.py
##########
@@ -96,6 +96,7 @@ def setUpClass(cls):
cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
cls.pod = get_pod(cls.apiclient, cls.zone.id)
cls.services['mode'] = cls.zone.networktype
+ cls.cleanup = []
Review comment:
cls.cleanup is defined AFTER the if statement which checks if the hypervisor
is supported.
if the hypervisor ISN't supported, the teardown still occurs but
```cleanup_resources(cls.apiclient, cls.cleanup)```
throws an exception because cls.cleanup hadn't been defined. @borisstoyanov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
