rafaelweingartner commented on a change in pull request #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#discussion_r222982084
########## File path: plugins/hypervisors/kvm/src/test/java/org/apache/cloudstack/utils/linux/KVMHostInfoTest.java ########## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.utils.linux; + +import org.apache.commons.lang.SystemUtils; + +import org.junit.Test; +import org.junit.Assume; +import org.mockito.Mockito; + +import org.libvirt.NodeInfo; + +public class KVMHostInfoTest { + @Test + public void getCpuSpeed() { Review comment: A test case without an assert? Also, why not mock things, and then always run the test? I mean, if somebody is using MacOS (not sure here) or Windows the test will be ignored. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
