rafaelweingartner commented on issue #2907: client: mgmt server listen default 
to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431018573
 
 
   Hey Folks, I was checking where this `bind.interface` is used.  We used it 
in the `ServerDaemon` class. We then pass it to 
`org.eclipse.jetty.server.AbstractNetworkConnector.setHost(String)` via a set 
method in 
`main.java.org.apache.cloudstack.ServerDaemon.createHttpConnector(HttpConfiguration)`
 and 
`main.java.org.apache.cloudstack.ServerDaemon.createHttpsConnector(HttpConfiguration)`.
 
   
   I then checked the ` AbstractNetworkConnector ` class. According to the 
documentation of the ` 
org.eclipse.jetty.server.AbstractNetworkConnector.getHost() `, if the `host` 
property is `null` or `0.0.0.0`, it will bind to all interfaces. If `0.0.0.0` 
only binds it to IPv4 interfaces, we can change line 122 of `ServerDaemon` to 
use the default as `null`, and then Jetty should bind to all interfaces.
   
   What do you guys think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to