bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231603522
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String
bridgeName) {
return "";
}
- String [] _ifNamePatterns = {
+ static String [] ifNamePatterns = {
Review comment:
@rafaelweingartner they can, but not sure that they can with CloudStack.
Actually, your idea that only "vnet" devices must be excluded is good but just
would like to get the opinion of other persons before changing that. In theory,
it can break someone's deployment even if our tests work well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
