rhtyd commented on a change in pull request #2905: Fix delete domain button in
the UI to update only after deleteDomain job finishes
URL: https://github.com/apache/cloudstack/pull/2905#discussion_r232546521
##########
File path: ui/scripts/domains.js
##########
@@ -69,11 +69,23 @@
async: false,
success: function(json) {
var jid = json.deletedomainresponse.jobid;
+ var wasDomainDeletedWithSuccess = false;
+ $.ajax({
+ url:
createURL("queryAsyncJobResult&jobId=" + jid),
+ dataType: "json",
+ async: false,
Review comment:
@rafaelweingartner sorry for a late reply, you don't need to query job
results manually but use `args.response.success` and pass the `jobId`. Ideally
an async notification callback could have been explored and used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
