GabrielBrascher commented on issue #3014: Remove unused StrategyPriority.PLUGIN
URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438244730
 
 
   @DaanHoogland there is no pratical need to remove this enum. I was just 
implementing KVM local to local storage migration and got a bit conserned if 
the `PLUGIN` priority could impact on my storage data motion strategy 
`canHandle` implementation. After looking into it I noticed that the respective 
enum is not used in any of our data motion strategy `canHandle` and decided to 
clean this up.
   
   **How it was verified:**
   Used Eclipse IDE to search for any reference for the 
`StrategyPriority.PLUGIN` enum. As I could not find any reference (except by 
the JUnit tests), I decided to play safe and run some file search looking for 
the text `PLUGIN` on CloudStack. The returned ones were not related to this 
enum. Thus, we don't have any sort of code (e.g. sql) running to set the 
strategy as "PLUGIN".
   
   Variables or values that contain the string `PLUGIN`: 
`NUAGE_VSP_PLUGIN_ERROR_MESSAGE`, `STORAGEPLUGINXML`, `PLUGINPATH`, 
`NFSPLUGIN`, `SAML2-PLUGIN` and `QUOTA-PLUGIN`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to