dhlaluku commented on a change in pull request #2793: Destroyvm also removes
volumes
URL: https://github.com/apache/cloudstack/pull/2793#discussion_r236531101
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -1857,8 +1857,13 @@ private void validateRootVolumeDetachAttach(VolumeVO
volume, UserVmVO vm) {
}
}
- private Volume orchestrateDetachVolumeFromVM(long vmId, long volumeId) {
+ @ActionEvent(eventType = EventTypes.EVENT_VOLUME_DETACH, eventDescription
= "detaching volume")
+ public Volume detachVolumeViaDestroyVM(long vmId, long volumeId) {
+ Volume result = orchestrateDetachVolumeFromVM(vmId, volumeId);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
