DaanHoogland commented on a change in pull request #2382: CLOUDSTACK-4045 IP
address acquired with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#discussion_r249758808
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -1417,6 +1408,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
+ protected boolean isSourceNatAvailableForNetwork(Account owner,
IPAddressVO ipToAssoc, Network network) {
Review comment:
@rafaelweingartner , wouldn't that just be describing the code in this
protected method? I'd rather see the code be more prozaic so i can just read
that (if need be)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
