rafaelweingartner commented on a change in pull request #2382: CLOUDSTACK-4045
IP address acquired with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#discussion_r249760721
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -1417,6 +1408,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
+ protected boolean isSourceNatAvailableForNetwork(Account owner,
IPAddressVO ipToAssoc, Network network) {
Review comment:
Well, for me, the java doc should present the idea of the method, and not
just describe the code. The code is the implementation of the idea. By idea
here I mean, the context where the given method fits in, the behavior we intend
it to have (from an input/output perspective), but not describing the
implementation at a line by line perspective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
