GabrielBrascher commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-458531422 @rhtyd the schedule is getting tight indeed, but I think that we can still merge this one. Reviews are looking good and overall the code is OK. If tests pass (they are looking good) and we have this PR stable, I have no concerns in merging it on 4.12.0.0. Said that, could you please fix the conflicting file? Thanks! The bigger issue that I see here (and also on my PRs #3154 and #2997) is the whole architecture as it is. As I mentioned in #3154, using the KvmNonManagedStorageDataMotionStrategy was the best that I could think regarding using the current architecture and easying future maintenance and extensions. Ideally, we should refactor this class structure and use proper O.O. However, this is not a simple task, and as such, I think it is best executed separated from any new feature introduction.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
