rhtyd commented on a change in pull request #3210: systemd: Fix -Dpid arg
passing to systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#discussion_r264584537
##########
File path: packaging/systemd/cloudstack-usage.service
##########
@@ -24,7 +24,8 @@ After=network.target network-online.target
[Service]
Type=simple
EnvironmentFile=/etc/default/cloudstack-usage
-ExecStart=/usr/bin/java $JAVA_OPTS -cp $CLASSPATH $JAVA_CLASS
+Environment=JAVA_PID=$$
Review comment:
@GabrielBrascher @andrijapanic moved the JAVA_PID here so users can't
change/mess it around. The systemd variable referencing is limiting, the fix
was to use the `${VAR}` syntax and not `$VAR` syntax. Can you believe it!
https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
