wido commented on a change in pull request #3186: Add possibility to set KVM
MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r265576235
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##########
@@ -1191,6 +1197,9 @@ public String toString() {
if (_networkName != null) {
netBuilder.append("<target dev='" + _networkName + "'/>\n");
}
+ if (NetUtils.isValidMtu(_mtu)) {
Review comment:
As we check it here we can just pass a null when the MTU is not set. No need
to hardcode 1500 in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
