falcon78921 commented on issue #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py URL: https://github.com/apache/cloudstack/pull/3174#issuecomment-475079046 @DaanHoogland I think some of the CI tests need updated to Python3. The ``.travis.yml`` is only testing on 2.7: https://github.com/apache/cloudstack/blob/master/.travis.yml#L25 I did change some of the Python modules (added ``pathlib``). Is there a place in the CI tests that need updated? I'm seeing ``AttributeErrors`` in some of the Travis tests (Job ``#15120.8``): https://travis-ci.org/apache/cloudstack/jobs/509174933 ~~~ ====================================================================== ERROR: test suite for <class 'integration.component.test_lb_secondary_ip.TestAssignLBRule'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", line 209, in run self.setUp() File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", line 315, in setupContext try_run(context, names) File "/home/travis/.local/lib/python2.7/site-packages/nose/util.py", line 471, in try_run return func() File "/home/travis/build/apache/cloudstack/test/integration/component/test_lb_secondary_ip.py", line 108, in setUpClass cls.zone.id, AttributeError: 'str' object has no attribute 'id' ~~~ So far, I don't see anything related to my PR in these errors. If I'm missing something, please let me know.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
