DaanHoogland commented on a change in pull request #3186: Add possibility to
set KVM MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r270346622
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1459,9 +1459,10 @@ public UserVm
updateDefaultNicForVirtualMachine(UpdateDefaultNicForVMCmd cmd) th
}
@Override
- public UserVm updateNicIpForVirtualMachine(UpdateVmNicIpCmd cmd) {
+ public UserVm updateNicIpMtuForVirtualMachine(UpdateVmNicIpMtuCmd cmd) {
Review comment:
service level call renaming is not as bad as API but migyht break third
party plugins as well!
Also I don't think it is needed, a small refactor and two methods, one
calling the other will do the trick.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
