nvazquez commented on a change in pull request #3251: [WIP DO NOT MERGE] Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#discussion_r271102538
########## File path: server/src/main/java/com/cloud/template/TemplateAdapterBase.java ########## @@ -284,35 +285,62 @@ public TemplateProfile prepare(RegisterTemplateCmd cmd) throws ResourceAllocatio } - @Override - public TemplateProfile prepare(GetUploadParamsForTemplateCmd cmd) throws ResourceAllocationException { + /** + * Prepare upload parameters internal method for templates and ISOs local upload + */ + private TemplateProfile prepareUploadParamsInternal(boolean isIso, long userId, String name, String displayText, Review comment: I could have used an object of the `TemplateProfile` class as parameter, but I think that can be confusing, as it is intended that the method returns a valid `TemplateProfile`. The one passed as parameter will just be a holder for the needed parameters and could cause confusion with the valid one. Do you agree? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services