DaanHoogland commented on a change in pull request #3312: 'sed -i' need postfix
on mac
URL: https://github.com/apache/cloudstack/pull/3312#discussion_r280418786
##########
File path: tools/apidoc/build-apidoc.sh
##########
@@ -61,8 +60,8 @@ set -e
cp "$thisdir"/*.java .
cp "$thisdir"/*.xsl .
sed -e 's,%API_HEADER%,All APIs,g' "$thisdir/generatetoc_header.xsl"
>generatetoc.xsl
- sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl
- sed -i "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatecommands.xsl
+ sed -i .bak "s/%ACS_RELEASE%/${ACS_RELEASE}/g" generatetoc.xsl
Review comment:
I think you are misreading the code,
line 62 redirects to a new file, from "$thisdir/generatetoc_header.xsl" to
generatetoc.xsl
then 63 operates on the resulting generatetoc.xsl
but 64 is operating on generatecommands.xsl
I don't think shell operations would allow redecting to input, it would
empty the file before openening it for read if you tried that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
