skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-491996665 @svenvogel now we should have the same behavior as nfs when selecting os type Windows* (except Windows PV) I think it might be better to select Windows PV and have all disk be virtio when para-virtualization is supported. With the current code vm created from iso templates with os type Windows* (Except Windows PV) will have an ide root disk but there is no way to attach a data disk as IDE. (one additional ide disk is possible before the error is triggered if i am not mistaken) I'm guessing @kiwiflyer 's PR will enable setting the disk controller when registering an iso similar to how this can be specified when registering a template. I think this would be a cleaner solution than trying to guess the controller / bus type based on the os type string.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
