DaanHoogland commented on a change in pull request #3331: api/server: Add
option 'details' to listProjects and listAccounts
URL: https://github.com/apache/cloudstack/pull/3331#discussion_r287991183
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java
##########
@@ -55,6 +61,12 @@
@Parameter(name = ApiConstants.STATE, type = CommandType.STRING,
description = "list accounts by state. Valid states are enabled, disabled, and
locked.")
private String state;
+ @Parameter(name = ApiConstants.DETAILS,
+ type = CommandType.LIST,
+ collectionType = CommandType.STRING,
+ description = "comma separated list of account details
requested, value can be a list of [ all, resource, min]")
+ private List<String> viewDetails;
Review comment:
You are right, @ustcweizhou . I think we can deprecate thiose and add better
parameter-names there as well. It is not so much the internal name,
'viewDetails' as the API parameter name, ApiConstants.DETAILS
(.equals("details")) which might be confusing as an external name,
The proposal is to change the bit ```@Parameter(name = ApiConstants.DETAILS,
...```. As it is new I don't think we can have a compatibility issue there.
For my part this can not block this PR btw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
