pbankonier edited a comment on issue #3294: Set default service offering over 
api and ui
URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577
 
 
   @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the 
code for the global default offering settings and found that the only place 
where this global config variables are used is in the ManagerImpls for the 
different offering types.
   
   
https://github.com/apache/cloudstack/blob/f7af27c3c87442e3a0df0f91e36d03c316434078/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java#L1302-L1330
   
   The global settings are just used to check if there is already an offering 
with the given "ID/UUID" existing in the database. (please look the picture 
below)
   
   
![image](https://user-images.githubusercontent.com/5433844/58962372-52cf8580-87ab-11e9-983b-caf95f597fb4.png)
   
   **There is no code which sets an offering to a default one with this 
configs. So maybe this was implemented to prevent that a new default offering 
was created at the start of the application before the uniquenames were 
introduced.**
   
   There is no need for a migration path with this PR. There will be no changes 
which will break existing functionality.
   
   1. users using this global settings will not be impacted by this changes 
because they do not set a default offering
   2. its now possible to set default offering over the UI/API instead of 
manipulating the database directly for SSVM, CSVM, LB and VR
   
   
![image](https://user-images.githubusercontent.com/5433844/58962941-852db280-87ac-11e9-8177-077b3947d72f.png)
   
   After my analysis the global default settings is doing close to nothing in 
the current state of the software and we can remove them and set this PR to the 
"standard".
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to