richardlawley opened a new pull request #3386: Fix labels broken by translation code URL: https://github.com/apache/cloudstack/pull/3386 ## Description <!--- Describe your changes in detail --> As discussed in #3385, the translation code does not work with self closing translate tags when there is other content at the same level, e.g. `<div><translate key="foo"/>: Something</div>` - it will remove the "`: Something`". This PR changes the affected tags to non-self closing, e.g. `<translate key="foo"></translate>: Something` This fixes the Zone names not being displayed on the capacity graphs on the dashboard, plus some minor missing labels elsewhere. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> Works around: #3385 ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): Before:  After:  ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Verified that missing labels appear in UI. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
