anuragaw opened a new pull request #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430 Regression was introduced in https://github.com/apache/cloudstack/commit/41fdb88970d1a33d57ff08a3ecc239ec898956dc#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174 The check introduced would fail and cause incorrect checks within same vlan tags. ## Description <!--- Describe your changes in detail --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> Fixes: #3114 ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Cloudmonkey- ``` (local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.1 endip=10.99.0.100 forsystemvms=false forVirtualNetwork=true { "vlan": { "account": "system", "domain": "ROOT", "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e", "endip": "10.99.0.100", "forsystemvms": false, "forvirtualnetwork": true, "gateway": "10.99.0.254", "id": "8f249bce-8210-4e79-bc02-7c9723970137", "netmask": "255.255.255.0", "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886", "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241", "startip": "10.99.0.1", "vlan": "vlan://untagged", "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727" } } (local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.101 endip=10.99.0.200 forsystemvms=false forVirtualNetwork=true { "vlan": { "account": "system", "domain": "ROOT", "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e", "endip": "10.99.0.200", "forsystemvms": false, "forvirtualnetwork": true, "gateway": "10.99.0.254", "id": "34d0b59b-4494-44cd-932e-c33f8f979b16", "netmask": "255.255.255.0", "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886", "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241", "startip": "10.99.0.101", "vlan": "vlan://untagged", "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727" } } (local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.190 endip=10.99.0.210 forsystemvms=false forVirtualNetwork=true Error 431: The IP range already has IPs that overlap with the new range. Please specify a different start IP/end IP. (local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=10.99.0.254 netmask=255.255.255.0 startip=10.99.0.201 endip=10.99.0.210 forsystemvms=false forVirtualNetwork=true { "vlan": { "account": "system", "domain": "ROOT", "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e", "endip": "10.99.0.210", "forsystemvms": false, "forvirtualnetwork": true, "gateway": "10.99.0.254", "id": "92abf2b6-44b3-416c-abd5-f331d718d8dc", "netmask": "255.255.255.0", "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886", "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241", "startip": "10.99.0.201", "vlan": "vlan://untagged", "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727" } } ``` <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
