anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299797574
##########
File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java
##########
@@ -101,9 +103,14 @@
* ha.retry.wait | time to wait before retrying the work item |
seconds | 120 || || stop.retry.wait | time to wait
* before retrying the stop | seconds | 120 || * }
**/
-public class HighAvailabilityManagerImpl extends ManagerBase implements
HighAvailabilityManager, ClusterManagerListener {
+public class HighAvailabilityManagerImpl extends ManagerBase implements
HighAvailabilityManager, ClusterManagerListener, Configurable {
protected static final Logger s_logger =
Logger.getLogger(HighAvailabilityManagerImpl.class);
+ private ConfigKey<Integer> MaxRetries = new ConfigKey<>("Advanced",
Integer.class,
+ "max.retries","5",
Review comment:
This is an old config file in the code but was not exposed to be configured.
Renaming makes sense. Doing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
