rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299806698
##########
File path: api/src/main/java/com/cloud/resource/ResourceState.java
##########
@@ -22,17 +22,26 @@
import com.cloud.utils.fsm.StateMachine;
public enum ResourceState {
- Creating, Enabled, Disabled, PrepareForMaintenance, ErrorInMaintenance,
Maintenance, Error;
+ Creating,
+ Enabled,
+ Disabled,
+ PrepareForMaintenance,
+ ErrorInMaintenance,
+ Maintenance,
+ Error,
+ PrepareForMaintenanceErrorsPresent;
Review comment:
(minor nit)
I understand, if the intent of the new state to say errors happened while
doing `...` then I'm simply asking the name of the new state to be uniform with
other state names. For example, `Maintenance` has `ErrorInMaintenance`; so
`PrepareForMaintenance` can have a similar `ErrorInPrepareForMaintenance`
state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
