nvazquez commented on a change in pull request #3500: kvm/bridge: Allow Link
Local Cidr (cloud0 interface) to be configured
URL: https://github.com/apache/cloudstack/pull/3500#discussion_r304709133
##########
File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java
##########
@@ -962,26 +962,29 @@ public static String getLinkLocalNetMask() {
}
public static String getLinkLocalGateway() {
- return "169.254.0.1";
+ return getLinkLocalFirstAddressFromCIDR(getLinkLocalCIDR());
}
public static String getLinkLocalCIDR() {
return "169.254.0.0/16";
Review comment:
Same as the comment above, instead of returning a hardcoded value, this
method can return the configured CIDR and can make `getLinkLocalGateway()`
above to be consistent with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
